Thread: Sending Email Asynchronously

Originally Posted by micky

Ok, its sometimes sending, sometimes not
Is it a slow process RR, i mean i am receiving mails with some delay??

Also its showing all addresses in TO field in mail!!

Oh....whoops....sorry micky....

Just realised that the for each loop is just adding each address to the to property, not sending the email as well....

The delay may be in your mail server...If you still have the whole function I posted, try setting the async flag (check_error, errorCheck or something) in the email function to check for errors and not send asyncronously to see if it makes any difference...

Originally Posted by richyrich

Oh....whoops....sorry micky....

Just realised that the for each loop is just adding each address to the to property, not sending the email as well....

The delay may be in your mail server...If you still have the whole function I posted, try setting the async flag (check_error, errorCheck or something) in the email function to check for errors and not send asyncronously to see if it makes any difference...

so how do i edit it to not show all addresses in TO field?

I'll try to check without async.

Originally Posted by micky

so how do i edit it to not show all addresses in TO field?

I'll try to check without async.

Try something like:-

Code:

    Public Shared Function SendMailUpdate(ByVal emails As String)
        Dim SmtpMail As New System.Net.Mail.SmtpClient(ConfigurationManager.AppSettings("SmtpServer"), 25)
        Dim myMail As New MailMessage()

        'SmtpMail.DeliveryMethod = SmtpDeliveryMethod.Network
        Dim arr_email_to As Array = Split(emails, ";")

        myMail.From = New MailAddress(ConfigurationManager.AppSettings("NoReply"))
        myMail.Body = ""
        myMail.Subject = "Update"
 
        Dim mailBox As Object = myMail
        AddHandler SmtpMail.SendCompleted, AddressOf SmtpClient_OnCompleted

        For Each email_to As String In arr_email_to
            myMail.To.Add(New MailAddress(email_to))
            SmtpMail.SendAsync(myMail, mailBox)
            myMail.Remove(0) 'not sure about the remove method, so might have to check if you use the index or the email address string.
        Next
 
    End Function

Ok, i'll try it RR.
But there is no remove property for myMail.

Sorry micky...Not really thinking straight today...

Try

Code:

For Each email_to As String In arr_email_to
myMail.To = email_to
SmtpMail.SendAsync(myMail, mailBox) 

Originally Posted by richyrich

Sorry micky...Not really thinking straight today...

Try

Code:

For Each email_to As String In arr_email_to
myMail.To = email_to
SmtpMail.SendAsync(myMail, mailBox) 

If i keep the SmtpMail.SendAsync line in For loop RR, i get this strange error!!

System.InvalidOperationException: RegisterForEventValidation can only be called during Render();

Originally Posted by micky

If i keep the SmtpMail.SendAsync line in For loop RR, i get this strange error!!

Workaround for this error was to add this

Code:

<%@ Page Language="VB" Async="true" EnableEventValidation="false" 

But then it says that already a async procedure is running.

So i assume that i cant have that SmtpMail.SendAsync line in For loop.

But it just keep sending all emails in TO field.
I think its the problem with system.net.mail.mailmessage.to, its a collection address

Any ideas anyone?

Ok, i made some changes and it seems to be working now.
Its sending mail one by one now.
Thanx RR

Code:

        Dim arr_email_to As Array = Split(emails, ";")

        For Each email_to As String In arr_email_to
            Dim SmtpMail As New SmtpClient(ConfigurationManager.AppSettings("SmtpServer"), 25)
            Dim myMail As New MailMessage()

            myMail.From = New MailAddress(ConfigurationManager.AppSettings("NoReply"))
            myMail.Body = "Update"
            myMail.Subject = "Update"

            myMail.To.Add(New MailAddress(email_to))
            SmtpMail.SendAsync(myMail, Nothing)
        Next

Originally Posted by micky

Workaround for this error was to add this

Code:

<%@ Page Language="VB" Async="true" EnableEventValidation="false" 

M, my only comment on this thread is regarding disabling Event Validation. Event Validation reduces the risk of unauthorized postbacks and callbacks. I would look into a better solution for this.

Originally Posted by jmurrayhead

M, my only comment on this thread is regarding disabling Event Validation. Event Validation reduces the risk of unauthorized postbacks and callbacks. I would look into a better solution for this.

I can remove that.

But ironically, now the code is showing emails in TO field again and also sending mails with different number of recipients to same person.
Darn