Discuss "Sessions being passed between users" in the .Net Development forum.

richyrich · #1 May 15th, 2008, 10:26 AM

I'm using forms authentication to log users into my site.

I've just tried testing it with another user and it seems our sessions were being shared between us.

All the pages have one master page and then content pages for each section.

When he logged in, his home page appeared fine. If I then refreshed my home page, my master page showed the correct details for me, but my content page was showing the information relating to the other user.

On my master page, I pass the userref to a public shared property within a seperate public class (App_Code/user_details) that stores the userref and is used to retrieve details about the user.
Master Page code:-

Code:

sub Page_Load()
.
.
.
user_details.pcuser = 
HttpContext.Current.User.Identity.Name()

user_details.vb code:-

Code:

Public Class user_details
 
  Private Shared _pcuser As Integer
  Public Shared Property pcuser() As Integer
      Get
          Return _pcuser
      End Get
      Set(ByVal value As Integer)
          _pcuser = value
      End Set
  End Property

When I use this property in my Master Page, for instance in a MySQL Parameter it seems to work fine:-

Code:

mycommand.parameters.addwithvalue("userref",user_details.pcuser)

But if I do the same within a content page, it's showing the information for whichever user refreshed the page most recently.

I assumed a Shared property was shared in the application by session, not by all the sessions connected.

I've used this methodology on a few sections of the site. I thought that was what seperate classes were used for. If I change it from Public Shared to something else, I can't then pass a value to it...

Have I done something fundamentally wrong?

How should I handle this?

Should I allocate it to a variable on the Master page and then reference that on my content pages. The problem with that is I also want to reference it within other seperate classes, from which I can't access Master Page variables.

Or is it to do with how the sessions are setup within my web.config?

Code:

<sessionState mode="InProc" cookieless="false" timeout="10" />

Some pointers would be much appreciated as I've built most of the site and hadn't realised this was an issue until today...

And on my birthday too....

jmurrayhead · #2 May 15th, 2008, 10:31 AM

You're declaring it as shared, thus the values will be overwritten and you will share that value.

richyrich · #3 May 15th, 2008, 10:34 AM

I thought that mean't shared between pages, not users.

So what should I change it to?

How should I pass the value from my pages to the class without it being overwritten?

jmurrayhead · #4 May 15th, 2008, 10:39 AM

You can use session variables:

Code:

Public Shared Property pcuser() As Integer
        Get
            Return HttpContext.Current.Session("pcuser")
        End Get
        Set(ByVal value As Integer)
            HttpContext.Current.Session("pcuser") = value
        End Set
End Property

richyrich · #5 May 15th, 2008, 10:45 AM

You mean set it as a session on my Master Page and then retrieve it in the class?
master page:-

Code:

HttpContext.Current.Session("pcuser") = HttpContext.Current.User.Identity.Name()

user_details.vb:-

Code:

Public Shared Property pcuser() As Integer
        Get
            Return HttpContext.Current.Session("pcuser")
        End Get
        Set(ByVal value As Integer)
            HttpContext.Current.Session("pcuser") = value
        End Set
End Property

jmurrayhead · #6 May 15th, 2008, 10:46 AM

Nope, just as you had it before. The property's SET will set the Session value

richyrich · #7 May 15th, 2008, 10:58 AM

I think I sorted it by just having:-

Code:

Public Shared ReadOnly Property pcuser() As Integer
        Get
            Return HttpContext.Current.User.Identity.Name()
        End Get
End Property

Phew....

Thanks J

I use the same methodology for gathering client details. One public class with a shared public property visitorref, which is set on the content pages where I need it. So, how could I handle this? If one user is viewing a client, the value could be changed by another user viewing a different client.

I'm reluctant to use session variables as I've had problems with them being lost in the past with classic ASP. At the moment the ref is passed by a querystring and then set to the shared property in the client_details class. Then it's easy to just use client_details.forename, for instance, to get the info you need on the page.

Any ideas?

richyrich · #8 May 15th, 2008, 11:04 AM

And I use it for a task system....

If I just change my pages so that I set the value of the relevant property in Page_Load, outside of If not IsPostBack then I presume the first thing it should do on Page_Load is set the value of the property to the correct value.

The scenario I'm thinking of is a user clicks to view a task and passes a value to the property. As they're typing an update, a different user views a task, which would change the value of the property again. But, if when the first user clicks update, the Page_load should pass back the value of the task they were viewing.

Is that right?

jmurrayhead · #9 May 15th, 2008, 11:10 AM

By making it shared...it is just that...shared. You're sharing the same resource, thus making this not good. You don't necessarily have to use session variables.

For example, you could have a class with public properties (not shared) that you populate every time the page loads.

Code:

Public Class UserInfo
    Private _userName As String = String.Empty
    Private _userEmail As String = String.Empty
 
    Public Property UserName() As String
        Get
            Return _userName
        End Get
        Set(ByVal value As String)
            _userName = value
        End Set
    End Property
 
    Public Property UserEmail() As String
        Get
            Return _userEmail
        End Get
        Set(ByVal value As String)
            _userEmail = value
        End Set
    End Property
End Class

Then every time a page is loaded:

Code:

Dim currentUser As New UserInfo()
    With currentUser
        .UserName = HttpContext.Current.User.Identity.Name
        .UserEmail = 'whatever you would get this information from
    End With

You could also create constructors for the UserInfo class as to make it a bit easier. In the UserInfo class:

Code:

Public Sub New(ByVal userName As String, ByVal userEmail As String)
    Me.UserName = userName
    Me.UserEmail = userEmail
End Sub

Then on your pages:

Code:

Dim currentUser As New UserInfo(HttpContext.Current.User.Identity.Name, "yourmom@mymom.com")

richyrich · #10 May 15th, 2008, 11:27 AM

It's more just the reference for each user, client, task etc. that I want to pass.

What about if I did this?
In my content pages have

Code:

Private task_details as New task_details()

Then in my task_details class, none of the properties are shared.

Would that solve the problem because they wouldn't be shared? Means I just have to add 1 line to each of my pages.

Thread Tools
Show Printable Version Email this Page
Display Modes
Linear Mode Switch to Hybrid Mode Switch to Threaded Mode

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
Make File/Folder restricted to only certain users	Rebelle	Microsoft IIS	16	March 26th, 2008 02:06 PM

Discuss "Sessions being passed between users" in the .Net Development forum.

.Net Development - Learn about the Microsoft.Net framework and how to create powerful web-based (ASP.net) and client-based (Windows Forms) applications utilizing various languages such as C#, VB.Net, J# and others.