Yep, icoombs is exactly right. You are passing values not variables. Also, I cleaned it up a bit. Use if you like:
Code:
Sub ComboMaker(strSQL, strSelectName, intID, strField, strSelected)
' -- Create Recordset --
Set rsDD = GetRS(strSQL)
' -- Create Select --
response.write "<select name=""" & strSelectName & """>" & vbCrLf
response.write "<option value="""">Select</option>" & vbCrLf
' -- Add Options --
If Not rsDD.EOF Then
Do While Not rsDD.EOF
response.write "<option value=""" & rsDD(intID) & """"
If CStr(rsDD(intID)) = CStr(strSelected) Then
response.write " selected"
End If
response.write ">" & rsDD(strField) & "</option>" & vbCrLf
rsDD.MoveNext
Loop
End If
' -- Close Select --
response.write "</select>"
' -- Close Connection --
rsDD.Close
Set rsDD = Nothing
End Sub
To call:
Code:
strSQL = "SELECT RegionID, RegionName FROM vwReg_Dist ORDER BY RegionName"
Call ComboMaker(strSQL, "MyRegName", "RegionID", "RegionName", Request("MyRegName"))
Bookmarks